Change InputBuffer::m_sizeInBytes default to UINT32_MAX #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m_sizeInBytes is only used for bounds checking, but we don't always have a valid size to go off of, particularly for user memory buffers. When possible, we will take advantage of it for the bounds check, but if it isn't available we should default to trusting the app to pass valid data. UINT32_MAX will always be greater than the attempted upload size, so this is a safe default in this case.
jenatali
approved these changes
Dec 11, 2023
vdwtanner
deleted the
user/tvandewalle/fixSizeCheckToAccountForIndexBuffers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_sizeInBytes is only used for bounds checking, but we don't always have a valid size to go off of, particularly for user memory buffers.
When possible, we will take advantage of it for the bounds check, but if it isn't available we should default to trusting the app to pass valid data. UINT32_MAX will always be greater than the attempted upload size, so this is a safe default in this case.