Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not create a command prompt window when running wsl.exe #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Holzhaus
Copy link

This prevents a CMD window from popping up when running wsl.exe (e.g., in a GUI application).

This prevents a CMD window from popping up when running `wsl.exe` (e.g.,
in a GUI application).
@Holzhaus
Copy link
Author

Holzhaus commented Jan 11, 2024

Disclaimer: I didn't test this, because I currently don't have private access to a Windows machine. Please verify this before hitting merge.

@michidk
Copy link
Owner

michidk commented Sep 14, 2024

Do you have an example scenario where a CMD window would pop up, so I can test this? I never saw this behavior.

@Holzhaus
Copy link
Author

Holzhaus commented Oct 5, 2024

Any time you execute this on windows (at least when running natively, not in WSL). The window just appears briefly. See neovide/neovide#2256 (comment).

@michidk
Copy link
Owner

michidk commented Oct 6, 2024

Ok makes sense.

Good job with Holzhaus/wslpath-rs! This here was just a workaround since I couldn't figure out how to do the conversion for some specific cases (which I cannot remember).

But since we have your pure rust implementation now, which does not depend on any external executable, I think it would be a good idea to deprecate this crate,

Or are there some features that are not yet fully supported by your implementation?

@Holzhaus
Copy link
Author

Holzhaus commented Oct 6, 2024

Or are there some features that are not yet fully supported by your implementation?

Only absolute paths are supported. Not sure if anything else also doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants