Add test case for #96

michaelbull · Apr 10, 2024 · c39888e · c39888e
1 parent 3a50dfa
commit c39888e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/kotlin-result/src/commonMain/kotlin/com/github/michaelbull/result/Binding.kt b/kotlin-result/src/commonMain/kotlin/com/github/michaelbull/result/Binding.kt
@@ -33,7 +33,7 @@ public inline fun <V, E> binding(crossinline block: BindingScope<E>.() -> V): Re
     return with(BindingScopeImpl<E>()) {
         try {
             Ok(block())
-        } catch (ex: BindException) {
+        } catch (_: BindException) {
             result!!
         }
     }

diff --git a/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/BindingTest.kt b/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/BindingTest.kt
@@ -78,4 +78,24 @@ class BindingTest {
             actual = result,
         )
     }
+
+    @Test
+    fun runCatchingInsideBindingDoesNotSwallow() {
+        fun squareNumber(): Result<Int, BindingError> = throw RuntimeException()
+
+        val squaredNumbers = binding<List<Int>, BindingError> {
+            val result: Result<List<Int>, Throwable> = runCatching {
+                (0..<10).map { number ->
+                    squareNumber().bind()
+                }
+            }
+
+            result.mapError { BindingError }.bind()
+        }
+
+        assertEquals(
+            expected = Err(BindingError),
+            actual = squaredNumbers,
+        )
+    }
 }