various cleanups #1292
Merged
various cleanups #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/cleanup
branch
2 times, most recently
from
8723246
to
e67bc74
Compare
|
Is this ready for review? |
|
Yes. |
When searching for the root of the code, we don't actually want the checkout root. In Docker, there won't actually be a checkout. Instead, we just want the root directory. This can be calculated based on the config module's path.
The module more resembles a query module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused prereqs.
Simplify the /v1/ URL handling in dev mode by using a mount, rather than a rewrite.
Move the search module to a query module, since it essentially matches the pattern of those modules.
Calculate the root directory based on the files, not based on git.