Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide scrolled search for ratings with a fake id #1218

Merged
merged 1 commit into from
May 14, 2024

Conversation

haarg
Copy link
Member

@haarg haarg commented May 12, 2024

MetaCPAN::Client still expects this to work, so provide some fake results.

@haarg haarg force-pushed the haarg/fake-rating-scroll branch 6 times, most recently from a467732 to 38a7aa6 Compare May 12, 2024 22:20
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 60.85%. Comparing base (76e879d) to head (31fcad7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
+ Coverage   60.70%   60.85%   +0.14%     
==========================================
  Files         163      163              
  Lines        4451     4460       +9     
  Branches      644      649       +5     
==========================================
+ Hits         2702     2714      +12     
+ Misses       1518     1510       -8     
- Partials      231      236       +5     
Files Coverage Δ
lib/MetaCPAN/Server/Controller/Scroll.pm 95.83% <100.00%> (+0.59%) ⬆️
lib/MetaCPAN/Server/Controller/Rating.pm 92.00% <75.00%> (+2.52%) ⬆️

... and 1 file with indirect coverage changes

@haarg haarg requested a review from mickeyn May 12, 2024 22:35
MetaCPAN::Client still expects this to work, so provide some fake
results.
@haarg haarg force-pushed the haarg/fake-rating-scroll branch from 38a7aa6 to 31fcad7 Compare May 13, 2024 00:49
@haarg haarg merged commit 37fe00c into master May 14, 2024
3 checks passed
@haarg haarg deleted the haarg/fake-rating-scroll branch May 14, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant