Only purge in latest script if making a change #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt to only purge changed dists in the latest script tried to only mark for purging when marking for upgrade or downgrade. But the if conditions to mark for upgrade/downgrade is not all of the logic. There are later conditions to limit which dists will be upgraded. Move the code marking dists to purge until after this later filtering.
haarg
force-pushed
the
haarg/latest-less-purge-v2
branch
from
f078e8d
to
caacca8
Compare
mickeyn
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to only purge changed dists in the latest script tried to only mark for purging when marking for upgrade or downgrade. But the if conditions to mark for upgrade/downgrade is not all of the logic. There are later conditions to limit which dists will be upgraded.
Move the code marking dists to purge until after this later filtering.