Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix installing rsync by specifying a minimum rather than exact version #1162

Merged
merged 1 commit into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. fix installing rsync by specifying a minimum rather than exact version

    hadolint complains about installing apt packages without specifying a
    version. For rsync, this is exceedingly unlikely to be a problem, but
    still in spirit it makes sense to be more explicit. Specifying the
    version explicitly has caused problems several times because our base
    image has changed, and the given versions are no longer available.
    
    Instead of specifying an exact package, we can use apt-get satisfy,
    which accepts a version string that can specify a minimum version.
    
    I'm not sure if hadolint understands apt-get satisfy, but this stops it
    from complaining. And it already wasn't complaining about not specifying
    jq's version.
    
    Also move the ignore rule about using a latest tag to an inline comment
    rather than in a separate file. This means it explicitly only covers the
    metacpan-base image, rather than any other image that could be in the
    file. Currently, there aren't any targets, but they could be added in
    the future and if they are using images that we don't control, we
    shouldn't be using latest.
    haarg committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    35729fa View commit details
    Browse the repository at this point in the history