Revert "Revert "Bug fix: fix param order (GH#1126)"" #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 781f214. The front end had been supplying the parameters incorrectly, and the API was accepting them incorrectly. So the front end was displaying correctly, but the API was incorrect. Fixing the API broke the pagination, which led to the original revert. The front end has now been fixed, so the API fix needs to be re-applied.
mickeyn
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 781f214.
The front end had been supplying the parameters incorrectly, and the API was accepting them incorrectly. So the front end was displaying correctly, but the API was incorrect. Fixing the API broke the pagination, which led to the original revert. The front end has now been fixed, so the API fix needs to be re-applied.