updated graphiql and react to the latest stable versions #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Oct 13, 2024
|
The reason for hard locking is that at some point they had a combination that didn't work. Hard locking prevents that. |
adrtivv
force-pushed
the
update_graphiql
branch
from
a98ba95
to
f267391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the graphiql and react versions to how they're used in the official graphiql example(link for reference) for the same.
Because of hard locking graphiql was locked to version 2.0.9 when the latest stable graphiql version is 3.7.1. The graphiql version 3.7.1 seems to work without issues with mercurius. React follows semantic versioning so no point in hard locking it to a patch version.
Update: Restored hard locking, versions are hard locked to the latest stable versions