-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade versions #142
Upgrade versions #142
Conversation
Skipping CI for Draft Pull Request. |
/test ? |
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.12-openshift-e2e |
b899450
to
f98758c
Compare
/test 4.12-openshift-e2e |
28c48a4
to
c6c8b49
Compare
/test 4.12-openshift-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
c6c8b49
to
8771081
Compare
/test 4.12-openshift-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on using Golang v1.21 for now, except that it looks lgtm.
… to 1.21) Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
I forgot that whenever we update operator-sdk it is better to update scorecard as well in https://github.com/medik8s/self-node-remediation/blob/main/config/scorecard/patches/basic.config.yaml#L7 and olm.config.yaml, and run |
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
/test 4.12-openshift-e2e |
/lgtm |
/retest |
1 similar comment
/retest |
Upgraded SNR Tools version.