Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update redirected URLs #35770

Merged
merged 5 commits into from
Sep 8, 2024
Merged

update redirected URLs #35770

merged 5 commits into from
Sep 8, 2024

Conversation

OnkarRuikar
Copy link
Contributor

It is crucial to update redirects before the URLs start throwing 404.

@OnkarRuikar OnkarRuikar requested review from a team as code owners September 6, 2024 08:27
@OnkarRuikar OnkarRuikar requested review from pepelsbey and willdurand and removed request for a team September 6, 2024 08:27
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:Learn Learning area docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Preview URLs (22 pages)
Flaws (45)

Note! 18 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/6
Title: Firefox 6 for developers
Flaw count: 13

  • macros:
    • /en-US/docs/Web/API/Element/dataset does not exist
    • /en-US/docs/Web/CSS/azimuth does not exist
    • /en-US/docs/Web/API/Element/dataset does not exist
  • broken_links:
    • Can't resolve /en-US/docs/XUL/Property/maxwidth
    • Can't resolve /en-US/docs/XPCOM_Interface_Reference/nsIDOMEventTarget
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons_for_Firefox_6
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces
    • Can't resolve /en-US/docs/XPCOM_Interface_Reference/nsIFileOutputStream#behavior_flag_constants
    • and 5 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/10
Title: Firefox 10 for developers
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/:-moz-full-screen-ancestor does not exist
    • /en-US/docs/Web/API/Window/navigator/mozBattery does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons_for_Firefox_10
    • Can't resolve /en-US/docs/PRBool
    • Can't resolve /en-US/docs/Install_Manifests#strictcompatibility
    • Can't resolve /en-US/docs/Extensions/Bootstrapped_extensions#Adding_user_interface_with_a_chrome.manifest

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
Flaw count: 19

  • macros:
    • /en-US/docs/Web/API/Worker/importScripts does not exist
    • /en-US/docs/Web/API/Element/onanimationstart does not exist
    • /en-US/docs/Web/API/Element/onanimationiteration does not exist
    • /en-US/docs/Web/API/Element/onanimationstart does not exist
    • /en-US/docs/Web/API/MozSocial does not exist
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Statements/for_each...in
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Simple_Push_API
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Alarm_API
    • and 8 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/4/Updating_extensions_for_Firefox_4
Title: Updating extensions for Firefox 4
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/XUL_Overlays
    • Can't resolve /en-US/docs/XPCOM/XPCOM_changes_in_Gecko_2.0
    • Can't resolve /en-US/docs/JavaScript_code_modules
    • Can't resolve /en-US/docs/Addons/Add-on_Manager/AddonManager
    • Can't resolve /en-US/docs/DOM/ChromeWorker
    • and 2 more flaws omitted
External URLs (59)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
Title: Sidebars


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Notifications
Title: Notifications


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Toolbar_button
Title: Toolbar button


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups
Title: Popups


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
Title: Context menu items


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Page_actions
Title: Address bar button


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Extension_pages
Title: Extension pages


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/devtools_panels
Title: devtools panels


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Options_pages
Title: Options page


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles
Title: Browser styles


URL: /en-US/docs/Mozilla/Firefox/Releases/6
Title: Firefox 6 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/10
Title: Firefox 10 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/24
Title: Firefox 24 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/4/Updating_extensions_for_Firefox_4
Title: Updating extensions for Firefox 4


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Introduction
Title: Introduction to client-side frameworks


URL: /en-US/docs/Learn/Common_questions/Tools_and_setup/What_software_do_I_need
Title: What software do I need to build a website?


URL: /en-US/docs/Learn/Common_questions/Tools_and_setup/How_much_does_it_cost
Title: How much does it cost to do something on the Web?


URL: /en-US/docs/Learn/Common_questions/Tools_and_setup/set_up_a_local_testing_server
Title: How do you set up a local testing server?


URL: /en-US/docs/Learn/Common_questions/Tools_and_setup/Available_text_editors
Title: What text editors are available?


URL: /en-US/docs/Learn/Common_questions/Tools_and_setup/Using_GitHub_pages
Title: How do I use GitHub Pages?

(comment last updated: 2024-09-08 17:19:52)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've personally excluded the 'Tools and setup' subtree from my dashboard (using the "configure include/exclude"). We need to renovate everything openwebdocs/project#207 and it's likely that many of the links don't work at all. From what I see, some of them are not redirecting to a page with the same purpose. What do you think?

Open to discussing about this though, I just haven't taken a look at this subtree. The requested changes are as below.

files/en-us/mozilla/firefox/releases/51/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/33/index.md Outdated Show resolved Hide resolved
@OnkarRuikar
Copy link
Contributor Author

A few points to discuss:
Why should we not use web archives? In the old FF release docs, we used them extensively because we wanted to preserve history.

  • Google decommissioned its URL shortener. That is why I think we need to be careful about non-reputed URL shorners.
  • The MDN warning tool needs a file that would maintain ignore list.

@Josh-Cena
Copy link
Member

The MDN warning tool needs a file that would maintain ignore list.

We already do; it's under config/.

Why should we not use web archives?

Web archives are used when we need to specifically point to one website; for example, "web technology X" that's now obsolete and the website has been decommissioned. On the other hand, if we are just linking to a blog post to illustrate a point, then we can just pick another article to achieve the same effect.

I don't have huge problems with web archives but:

  1. Sometimes sites are just off transiently. If we keep the link, it may be fixed without any action from us.
  2. Web archives are slow to open, not automatically checkable, and are "stuck" forever.

we need to be careful about non-reputed link shorteners.

I'm fairly sure that this is an official Mozilla shortener, no?

Google is infamous for tearing down its own products. I don't think we need to distrust other shorteners, especially when it has already been there for many years.

@Josh-Cena Josh-Cena merged commit 33cada2 into mdn:main Sep 8, 2024
9 checks passed
@OnkarRuikar OnkarRuikar deleted the content_redirects branch September 9, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn Learning area docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants