Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: CSS flex guide: updates to guide 2 #34149

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Maintenance: CSS flex guide: updates to guide 2 #34149

merged 2 commits into from
Jun 14, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 14, 2024

just freshens up the guide.

  • remove historical information
  • de-capitalize to match mdn guidelines
  • checked stuff to make sure it was accurate (and it mostly was)
  • removed "fallback" type language.
  • display contents was fixed, then it wasn't, then it was partially, so made the warning more generic so it stands the test of time

addressed as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 14, 2024 07:07
@estelle estelle requested review from chrisdavidmills and removed request for a team June 14, 2024 07:07
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_flexible_box_layout/Relationship_of_flexbox_to_other_layout_methods
Title: Relationship of flexbox to other layout methods

(comment last updated: 2024-06-14 19:37:19)

@estelle estelle mentioned this pull request Jun 14, 2024
Closed
29 tasks
chrisdavidmills
chrisdavidmills approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle nice work. Just a few bits to go through, nothing major. I'll approve so as not to hold you up.

...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
...-us/web/css/css_flexible_box_layout/relationship_of_flexbox_to_other_layout_methods/index.md Outdated Show resolved Hide resolved
@estelle @chrisdavidmills
Apply suggestions from code review
3f2cd97 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle merged commit 82bcebc into main Jun 14, 2024
9 checks passed
@estelle estelle deleted the flex-guide2 branch June 14, 2024 19:51
@evelinabe evelinabe mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills