Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on boilerplates package #5

Merged
merged 8 commits into from
Sep 2, 2023
Merged

Conversation

mbdevpl
Copy link
Owner

@mbdevpl mbdevpl commented Sep 2, 2023

No description provided.

@mbdevpl mbdevpl self-assigned this Sep 2, 2023
@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Sep 2, 2023

Tools report for GitHub-mbdevpl/argunparse/PR-5 [build #1]:

  • Pylint: ran 🆗

  • Mypy: problems ⚠️ (click for details)
    test/examples.py:20: error: "object" has no attribute "items"  [attr-defined]
    test/examples.py:38: error: Need type annotation for "ARGUMENTS_SKIPPED" (hint: "ARGUMENTS_SKIPPED: Dict[<type>, <type>] = ...")  [var-annotated]
    argunparse/argument_unparser.py:114: error: Unsupported operand types for + ("str" and "list[str]")  [operator]
    argunparse/argument_unparser.py:114: error: No overload variant of "__add__" of "list" matches argument type "str"  [operator]
    argunparse/argument_unparser.py:114: note: Possible overload variants:
    argunparse/argument_unparser.py:114: note:     def __add__(self, list[str], /) -> list[str]
    argunparse/argument_unparser.py:114: note:     def [_S] __add__(self, list[_S], /) -> list[_S | str]
    argunparse/argument_unparser.py:114: note: Both left and right operands are unions
    argunparse/argument_unparser.py:120: error: Argument 1 to "join" of "str" has incompatible type "list[str | list[str]]"; expected "Iterable[str]"  [arg-type]
    argunparse/argument_unparser.py:129: error: Incompatible return value type (got "str | list[str]", expected "list[Any]")  [return-value]
    argunparse/argument_unparser.py:136: error: Incompatible return value type (got "str | list[str]", expected "str")  [return-value]
    Found 7 errors in 2 files (checked 8 source files)
    
  • Flake518: ran 🆗

  • Pydocstyle: ran 🆗

  • Coverage: 99% 🆗 (click for details)
    Name                              Stmts   Miss Branch BrPart  Cover   Missing
    -----------------------------------------------------------------------------
    argunparse/__init__.py                2      0      0      0   100%
    argunparse/_version.py                2      0      0      0   100%
    argunparse/argument_unparser.py      91      1     42      0    99%   139
    setup.py                              9      0      2      0   100%
    test/__init__.py                      6      0      0      0   100%
    test/examples.py                     12      0      4      0   100%
    test/test_argument_unparser.py      105      0     44      2    99%   120->123, 125->116
    test/test_packaging.py                3      0      0      0   100%
    -----------------------------------------------------------------------------
    TOTAL                               230      1     92      2    99%
    

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #5 (33d03d4) into main (2ca7c67) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   99.06%   99.55%   +0.49%     
==========================================
  Files           9        8       -1     
  Lines         641      227     -414     
  Branches      123       44      -79     
==========================================
- Hits          635      226     -409     
+ Misses          4        1       -3     
+ Partials        2        0       -2     
Files Changed Coverage Δ
setup.py 100.00% <100.00%> (ø)
test/__init__.py 100.00% <100.00%> (ø)
test/test_argument_unparser.py 100.00% <100.00%> (+0.97%) ⬆️
test/test_packaging.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Sep 2, 2023

Tools report for GitHub-mbdevpl/argunparse/PR-5 [build #2]:

  • Pylint: warnings ⚠️ (click for details)
    Unable to create directory /home/user/.cache/pylint
    Unable to create file /home/user/.cache/pylint/setup_1.stats: [Errno 2] No such file or directory: '/home/user/.cache/pylint/setup_1.stats'
    ************* Module test.test_argument_unparser
    test/test_argument_unparser.py:6:0: W0611: Unused import sys (unused-import)
    
    -----------------------------------
    Your code has been rated at 9.96/10
    
  • Mypy: problems ⚠️ (click for details)
    test/examples.py:20: error: "object" has no attribute "items"  [attr-defined]
    test/examples.py:38: error: Need type annotation for "ARGUMENTS_SKIPPED" (hint: "ARGUMENTS_SKIPPED: Dict[<type>, <type>] = ...")  [var-annotated]
    argunparse/argument_unparser.py:114: error: Unsupported operand types for + ("str" and "list[str]")  [operator]
    argunparse/argument_unparser.py:114: error: No overload variant of "__add__" of "list" matches argument type "str"  [operator]
    argunparse/argument_unparser.py:114: note: Possible overload variants:
    argunparse/argument_unparser.py:114: note:     def __add__(self, list[str], /) -> list[str]
    argunparse/argument_unparser.py:114: note:     def [_S] __add__(self, list[_S], /) -> list[_S | str]
    argunparse/argument_unparser.py:114: note: Both left and right operands are unions
    argunparse/argument_unparser.py:120: error: Argument 1 to "join" of "str" has incompatible type "list[str | list[str]]"; expected "Iterable[str]"  [arg-type]
    argunparse/argument_unparser.py:129: error: Incompatible return value type (got "str | list[str]", expected "list[Any]")  [return-value]
    argunparse/argument_unparser.py:136: error: Incompatible return value type (got "str | list[str]", expected "str")  [return-value]
    Found 7 errors in 2 files (checked 8 source files)
    
  • Flake518: problems ⚠️ (click for details)
    test/test_argument_unparser.py:6:1: F401 'sys' imported but unused
    
  • Pydocstyle: ran 🆗

  • Coverage: 99% 🆗 (click for details)
    Name                              Stmts   Miss Branch BrPart  Cover   Missing
    -----------------------------------------------------------------------------
    argunparse/__init__.py                2      0      0      0   100%
    argunparse/_version.py                2      0      0      0   100%
    argunparse/argument_unparser.py      91      1     42      0    99%   139
    setup.py                              9      0      2      0   100%
    test/__init__.py                      6      0      0      0   100%
    test/examples.py                     12      0      4      0   100%
    test/test_argument_unparser.py      103      0     40      0   100%
    test/test_packaging.py                3      0      0      0   100%
    -----------------------------------------------------------------------------
    TOTAL                               228      1     88      0    99%
    

@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Sep 2, 2023

Tools report for GitHub-mbdevpl/argunparse/PR-5 [build #3]:

  • Pylint: ran 🆗

  • Mypy: problems ⚠️ (click for details)
    test/examples.py:20: error: "object" has no attribute "items"  [attr-defined]
    test/examples.py:38: error: Need type annotation for "ARGUMENTS_SKIPPED" (hint: "ARGUMENTS_SKIPPED: Dict[<type>, <type>] = ...")  [var-annotated]
    argunparse/argument_unparser.py:114: error: Unsupported operand types for + ("str" and "list[str]")  [operator]
    argunparse/argument_unparser.py:114: error: No overload variant of "__add__" of "list" matches argument type "str"  [operator]
    argunparse/argument_unparser.py:114: note: Possible overload variants:
    argunparse/argument_unparser.py:114: note:     def __add__(self, list[str], /) -> list[str]
    argunparse/argument_unparser.py:114: note:     def [_S] __add__(self, list[_S], /) -> list[_S | str]
    argunparse/argument_unparser.py:114: note: Both left and right operands are unions
    argunparse/argument_unparser.py:120: error: Argument 1 to "join" of "str" has incompatible type "list[str | list[str]]"; expected "Iterable[str]"  [arg-type]
    argunparse/argument_unparser.py:129: error: Incompatible return value type (got "str | list[str]", expected "list[Any]")  [return-value]
    argunparse/argument_unparser.py:136: error: Incompatible return value type (got "str | list[str]", expected "str")  [return-value]
    Found 7 errors in 2 files (checked 8 source files)
    
  • Flake518: ran 🆗

  • Pydocstyle: ran 🆗

  • Coverage: 99% 🆗 (click for details)
    Name                              Stmts   Miss Branch BrPart  Cover   Missing
    -----------------------------------------------------------------------------
    argunparse/__init__.py                2      0      0      0   100%
    argunparse/_version.py                2      0      0      0   100%
    argunparse/argument_unparser.py      91      1     42      0    99%   139
    setup.py                              9      0      2      0   100%
    test/__init__.py                      6      0      0      0   100%
    test/examples.py                     12      0      4      0   100%
    test/test_argument_unparser.py      102      0     40      0   100%
    test/test_packaging.py                3      0      0      0   100%
    -----------------------------------------------------------------------------
    TOTAL                               227      1     88      0    99%
    

@mbdevpl mbdevpl merged commit ce83f21 into main Sep 2, 2023
18 checks passed
@mbdevpl mbdevpl deleted the feature/boilerplate-package branch September 2, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant