Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cookie refresh bug #876

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Aug 10, 2024

  1. fixed cookie refresh bug

    Issue maxcountryman#824. Before, if a user was logged in with the login_user function when the remember parameter was set to false, their cookies would still be refreshed if the "REMEMBER_COOKIE_REFRESH_EACH_REQUEST" configuration option was set to true. This happens because if the login_user function has the remember parameter be false, it doesn't assign session["_rememeber"] any value. When session["_rememeber"] doesn't have any value and the "REMEMBER_COOKIE_REFRESH_EACH_REQUEST" configuration option is set to true, the _update_remember_cookie function sets the session["_rememeber"] value to "set". This fix makes it so if the login_user function is given false for the remember parameter, instead of leaving session["_remember"] empty, it  sets the value to "unset".
    Arcane-Ryn committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    0754f68 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Added unit tests to demonstrate bugfix

    Added unit tests for each different combination of values for the "remember" and "REMEMBER_COOKIE_REFRESH_EACH_REQUEST" values.
    Arcane-Ryn committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    824127d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e96789 View commit details
    Browse the repository at this point in the history
  3. Fixed code formatting

    Arcane-Ryn committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3e8f779 View commit details
    Browse the repository at this point in the history
  4. even more formatting

    Arcane-Ryn committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5638c48 View commit details
    Browse the repository at this point in the history