Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Infra Fixes #2

Merged
merged 1 commit into from
Aug 14, 2023
Merged

More Infra Fixes #2

merged 1 commit into from
Aug 14, 2023

Conversation

matteosox
Copy link
Owner

Summary

More infrastructural fixes.

Why?

We want to get CICD working.

How?

  • Omit protobuf autogen code from coverage tests.
  • Add github token to publish Github Action workflow step.
  • Add write permission to github token to create/edit the Github release.

Checklist

Most checks are automated, but a few aren't, so make sure to go through and tick them off, even if they don't apply. This checklist is here to help, not deter you. Remember, "Slow is smooth, and smooth is fast".

  • Unit tests
    • Every input should have a test for it.
    • Every potential raised exception should have a test ensuring it is raised.
  • Documentation
    • New functions/classes/etc. must be added to docs/api.rst.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
    • The appropriate entry in CHANGELOG.md has been included in the "Unreleased" section, i.e. "Added", "Changed", "Deprecated", "Removed", "Fixed", or "Security".
  • Future work
    • Future work should be documented in the contributor guide, i.e. .github/CONTRIBUTING.md.

If you have any questions not answered by a quick readthrough of the contributor guide, add them to this PR and submit it.

- Add github token to publish Github Action workflow step.
- Add write permission to github token to create/edit the Github release.
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.06% 🎉

Comparison is base (b944311) 52.22% compared to head (6696098) 54.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   52.22%   54.28%   +2.06%     
==========================================
  Files          15       14       -1     
  Lines         720      676      -44     
  Branches       98       97       -1     
==========================================
- Hits          376      367       -9     
+ Misses        341      307      -34     
+ Partials        3        2       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteosox matteosox merged commit fcfdf40 into main Aug 14, 2023
15 checks passed
@matteosox matteosox deleted the matt/more-infra-fixes branch August 14, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant