add task solution #4902
add task solution #4902
Conversation
alechsva
commented
Oct 19, 2024
alechsva
commented
- DEMO LINK
- TEST REPORT LINK
- there 2 BEM blocks card and stars each in it own file
- SCSS Nesting is used for elements, modifiers and pseudo-classes
- SCSS Variables are used for main values and placed in a separate file
- all stars--N modifiers work as expected (Highlight first N stars)
- Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
Great job on maintaining a clean and organized codebase! 🎉 While there are a couple of minor suggestions for improvement, they don't impact the functionality. Keep up the excellent work and consider the feedback for future enhancements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| font-style: $style; | ||
| } | ||
|
|
||
| @mixin border($size, $color, $radius: none) { |
There was a problem hiding this comment.
The default value for $radius should be 0 instead of none to ensure proper CSS syntax, as none is not a valid value for border-radius.
| } | ||
| } | ||
|
|
||
| &.stars--4 > .stars__star:nth-child(-n + 4) { |
There was a problem hiding this comment.
The selector .stars--4 > .stars__star:nth-child(-n + 4) is quite specific. Ensure that this specificity is necessary and does not conflict with other styles. Consider using a more general class or a modifier if possible.
