add task solution #4893
add task solution #4893
Conversation
RomanHasiuk
commented
Oct 17, 2024
RomanHasiuk
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
It looks like there are a few critical issues that need to be addressed before we can proceed. The typos in the class name and font-family could lead to styling issues, and the incorrect href attribute pointing to a SCSS file might cause the styles not to load properly. Please fix these issues, and you'll be all set! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <title>Product cards</title> | ||
| <link | ||
| rel="stylesheet" | ||
| href="./styles/index.scss" |
There was a problem hiding this comment.
The href attribute is pointing to a SCSS file. Typically, browsers do not understand SCSS directly. Ensure that this file is being compiled to CSS and link to the CSS file instead.
src/index.html
Outdated
| </div> | ||
|
|
||
| <div class="card__price-container"> | ||
| <div class="card__price-lebel">Price:</div> |
There was a problem hiding this comment.
There is a typo in the class name 'card__price-lebel'. It should be 'card__price-label'.
src/styles/index.scss
Outdated
| $main-color: #00acdc; | ||
|
|
||
| .page { | ||
| font-family: Roboto, Aria, sans-serif; |
There was a problem hiding this comment.
There is a typo in the font-family declaration. It should be 'Arial' instead of 'Aria'.
src/styles/index.scss
Outdated
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| &__price-lebel { |
There was a problem hiding this comment.
There is a typo in the class name. It should be '&__price-label' instead of '&__price-lebel'.
There was a problem hiding this comment.
Great job on the pull request! 🎉 There are a couple of minor issues to address: ensure the &:last-child selector is correctly placed, and update the href attribute to point to a CSS file. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <title>Product cards</title> | ||
| <link | ||
| rel="stylesheet" | ||
| href="./styles/index.scss" |
There was a problem hiding this comment.
The href attribute in the <link> tag should point to a CSS file, not an SCSS file. Ensure that the path is correct and points to a compiled CSS file.
src/styles/index.scss
Outdated
| &:last-child { | ||
| margin-right: 0; | ||
| } |
There was a problem hiding this comment.
The &:last-child selector is incorrectly placed inside the .stars block. It should be inside the .stars__star block to correctly target the last star element.
