made catalog #4789
made catalog #4789
Conversation
VladStep186
commented
Oct 22, 2024
VladStep186
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
It looks like there are a couple of issues that need to be addressed before we can approve this pull request. The color value format and the CSS selector need corrections to ensure the code functions as intended. Once these are fixed, you'll be all set! Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/styles/cards.scss
Outdated
| &:hover &__title { | ||
| color: #34568b; | ||
| } |
There was a problem hiding this comment.
The selector &:hover &__title is incorrect because it implies that &__title is a descendant of &:hover, which is not possible. You might want to use &:hover .card__title instead to target the .card__title element when the .card is hovered.
src/styles/header.scss
Outdated
| align-items: center; | ||
| justify-content: space-between; | ||
| padding: 0 50px; | ||
| box-shadow: 0 2px 4px 0 #0000000d; |
There was a problem hiding this comment.
The color value '#0000000d' seems to be using an incorrect format. The correct format for a color with alpha transparency in hexadecimal is '#RRGGBBAA'. Please ensure the alpha value is correctly formatted.
There was a problem hiding this comment.
Great job on your SCSS files! 🎉 Your use of BEM methodology and CSS variables is commendable. While the hover selector could be improved for better adherence to BEM principles, the overall structure and consistency of your code are impressive. Keep up the good work, and make sure to address the hover selector issue in future projects to enhance your skills further. Keep learning and improving! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/styles/cards.scss
Outdated
| &:hover .card__title { | ||
| color: #34568b; | ||
| } |
There was a problem hiding this comment.
The selector &:hover .card__title might not work as expected because BEM methodology suggests using a single class for each element. Consider using a more specific class for the hover state.
src/styles/main.scss
Outdated
| --column-count: 1; | ||
|
|
||
| display: grid; | ||
| grid-template-columns: repeat(auto-fill, 200px); |
There was a problem hiding this comment.
you need to use your var here
instead of auto-fill
