Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved #1294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solved #1294

wants to merge 2 commits into from

Conversation

igols
Copy link

@igols igols commented Oct 21, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 Just make sure that each input element has a 'name' attribute to avoid any potential errors. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


label.classList.add('field-label');
label.setAttribute('for', item.id);
label.textContent = item.getAttribute('name');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAttribute('name') method is used here to set the label's text content. Ensure that each input element has a 'name' attribute, otherwise this will return null and the label will be empty.

label.classList.add('field-label');
label.setAttribute('for', item.id);
label.textContent = item.getAttribute('name');
item.setAttribute('placeholder', capitalize(item.getAttribute('name')));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, ensure that the 'name' attribute exists for each input element. If it doesn't, getAttribute('name') will return null, and the capitalize function will throw an error because null does not have a method at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants