fix auth form #1290
fix auth form #1290
Conversation
AnnNikiforova
commented
Oct 18, 2024
AnnNikiforova
commented
- DEMO LINK
There was a problem hiding this comment.
Great job on the Pull Request! 🎉 While there are a couple of assumptions in the code regarding 'name' and 'id' attributes, they don't critically impact functionality. Just keep an eye on these details in future projects to ensure robustness. Keep up the good work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const label = document.createElement('label'); | ||
|
|
||
| label.classList.add('field-label'); | ||
| label.setAttribute('for', input.id); |
There was a problem hiding this comment.
This line assumes that every input element has an 'id' attribute. If an input does not have an 'id', this will set the 'for' attribute to an empty string, which may not be the intended behavior. Consider adding a check to ensure the input has an 'id' before setting the 'for' attribute.
src/scripts/main.js
Outdated
| label.setAttribute('for', input.id); | ||
|
|
||
| label.textContent = | ||
| input.name.charAt(0).toUpperCase() + input.name.slice(1); |
There was a problem hiding this comment.
This line assumes that every input element has a 'name' attribute. If an input does not have a 'name', this will result in an error. Consider adding a check to ensure the input has a 'name' before attempting to access it.
