Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for
aiohttp
as api clientQuestion
Since the
aiohttp.ClientResponse
has different names for common attribute (status for status_code) and also they are async attributes (e.g response.json), maybe implement a generic Response and fill it up depending on the type of client?E.g here it will fail or give an error since aiohttp doesn't have a status_code attr, idem here for json.
Related Issue
#4
PD
I didn't implement tests since there aren't tests for the other clients