Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of jsx files to tsx 2 #850

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Migration of jsx files to tsx 2 #850

merged 9 commits into from
Dec 22, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 21, 2023 •
edited
Loading

This is to continue the work of migrating all the jsx files into tsx files.
The MO is basically described here: #848.

About 7 files to go...

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 21, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a192b04:

Sandbox Source
maputnik Configuration

@HarelM HarelM requested a review from nyurik December 22, 2023 08:12
nyurik
nyurik approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursory examination looks good, but i might have missed something

@HarelM HarelM merged commit 974dd7b into maplibre:main Dec 22, 2023
8 checks passed
@HarelM HarelM deleted the typescript4 branch December 22, 2023 21:34
@HarelM HarelM mentioned this pull request Dec 22, 2023
Merged
HarelM added a commit that referenced this pull request Dec 25, 2023
@HarelM
Migration of jsx files to tsx 3 (#851)
656264f 
This is in continue to:
- #850
- #848

The last files should be converted as part of this PR, there are only a
handful left.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

@birkskyum birkskyum Awaiting requested review from birkskyum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarelM @nyurik