Refactor driver for E2E #841
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 026cf95:
|
|
I've generated a package lock file and updated the package.json, can you try replacing the ones you have? |
| id = `${type}:${uuid()}`; | ||
| } | ||
|
|
||
| cy.get( |
There was a problem hiding this comment.
Doesn't the helper support select?
| cy.get( | ||
| this.get.getDataAttribute("add-layer.layer-type", "select") | ||
| ).select(type); | ||
| cy.get(this.get.getDataAttribute("add-layer.layer-id", "input")).type(id); |
There was a problem hiding this comment.
I would expect, hopefully, to completely remove the method this.get.getDataAttribute by using the helper class, is it possible?
|
Npm ci now passes, but it has a different build error... |
|
|
|
I've seen this before in a different library, but I'm not sure what triggered this build failure here... |
|
Unfortunately, yes |
|
I would try to take the original jsx files before the changes and see if they cause a build failure, if not, then we need to understand what was introduced in this PR that caused the build to fail. |
|
Reverting locally the jsx file seems to fix the build locally, so I guess there are changes that break the build somehow...
|
|
I'll move this to a branch over here so we can collaborate on this. |
This is basically the content of #841 with the code review changes and relevant fixes to tests/driver code to pass the tests. CC: @ShellyDCMS After this we should lint the project and add the lint to the CI to make sure it doesn't break. --------- Co-authored-by: ShellyDCMS <60476837+ShellyDCMS@users.noreply.github.com> Co-authored-by: shelly_goldblit <shelly_goldblit@dell.com>
Added shellygo package.
Refactor driver and e2e tests.
Added data-wd attributes to missing places.