Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nginx to serve built files #808

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Use nginx to serve built files #808

merged 2 commits into from
Dec 26, 2023

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Apr 21, 2023

Resolves #842
Better suited than python + handles sigterm better

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec96f45:

Sandbox Source
maputnik Configuration

Dockerfile Outdated Show resolved Hide resolved
@nbr23 nbr23 requested a review from nyurik April 21, 2023 20:18
@HarelM
Copy link
Collaborator

HarelM commented Dec 26, 2023

No reason not to add this.
The only difference is that this exposes port 80 while the original image eposes port 8888.
Having said that this is a breaking change version and it makes sense.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a22476c) 56.77% compared to head (ec96f45) 56.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         104      104           
  Lines        2929     2929           
  Branches      674      674           
=======================================
  Hits         1663     1663           
  Misses       1266     1266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 09a1f3f into maplibre:main Dec 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce docker image size
4 participants