Added vtt cue settings to internal format #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #64
It keeps inline the vtt cue settings in internal_format as
$internal_format['vtt_cue_settings']
.when the vtt is created, it checks for $internal_format['vtt_cue_settings'] and attaches it to the end of the vtt time line.
To pass tests and keep the code consistent, there should be additional parameter passed to add() for the vtt cue settings.
like
->add(0, 10, 'Hello world.', ['vtt_cue_settings' => 'position:50% line:15% align:middle'])
-i used an array which makes it possible for passing extra settings as the 4th param in the future -