Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vtt cue settings to internal format #79

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

vnali
Copy link
Contributor

@vnali vnali commented Aug 1, 2023

This PR is related to #64

It keeps inline the vtt cue settings in internal_format as $internal_format['vtt_cue_settings'].

when the vtt is created, it checks for $internal_format['vtt_cue_settings'] and attaches it to the end of the vtt time line.

To pass tests and keep the code consistent, there should be additional parameter passed to add() for the vtt cue settings.
like ->add(0, 10, 'Hello world.', ['vtt_cue_settings' => 'position:50% line:15% align:middle'])
-i used an array which makes it possible for passing extra settings as the 4th param in the future -

@mantas-done mantas-done merged commit d1d9335 into mantas-done:master Aug 2, 2023
2 checks passed
@mantas-done
Copy link
Owner

Merged. Thank you.

@vnali
Copy link
Contributor Author

vnali commented Aug 3, 2023

Thanks @mantas-done
Perhaps the 4th parameter for add() should be mentioned in the document page?

@mantas-done
Copy link
Owner

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants