Fix vtt parsing

mantas-done · Dec 4, 2023 · 4bf51c9 · 4bf51c9
1 parent 5960e28
commit 4bf51c9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/Code/Converters/VttConverter.php b/src/Code/Converters/VttConverter.php
@@ -54,7 +54,7 @@ public function fileContentToInternalFormat($file_content, $original_file_conten
                         unset($internal_format[$i - 1]['lines'][$count - 1]);
                     }
                 }
-            } elseif (TxtConverter::hasText($line)) {
+            } elseif (trim($line) !== '') {
                 $text_line = $line;
                 // speaker
                 $speaker = null;

diff --git a/tests/formats/VttTest.php b/tests/formats/VttTest.php
@@ -387,4 +387,25 @@ public function testTextIsNotRecognizedAsTimestamp()
             ->getInternalFormat();
         $this->assertEquals($expected, $actual);
     }
+
+    public function testClientFile()
+    {
+        $given = <<< TEXT
+WEBVTT
+
+1
+00:00:00.000 --> 00:00:01.000
+a
+
+2
+00:00:01.000 --> 00:00:02.000
+b
+TEXT;
+        $actual = (new Subtitles())->loadFromString($given)->getInternalFormat();
+        $expected = (new Subtitles())
+            ->add(0, 1, 'a')
+            ->add(1, 2, 'b')
+            ->getInternalFormat();
+        $this->assertEquals($expected, $actual);
+    }
 }