Fix Smi exception

mantas-done · Apr 23, 2024 · 2c95999 · 2c95999
1 parent 2a3f690
commit 2c95999
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Code/Converters/SmiConverter.php b/src/Code/Converters/SmiConverter.php
@@ -93,7 +93,7 @@ public function fileContentToInternalFormat($file_content, $original_file_conten
                 $i++;
             }
         }
-        if (!isset($internal_format[$i - 1]['end'])) {
+        if (isset($internal_format[$i - 1]['start']) && !isset($internal_format[$i - 1]['end'])) {
             $internal_format[$i - 1]['end'] = $internal_format[$i - 1]['start'] + 1;
         }
 

diff --git a/tests/formats/SmiTest.php b/tests/formats/SmiTest.php
@@ -4,6 +4,7 @@
 
 use Done\Subtitles\Code\Converters\SmiConverter;
 use Done\Subtitles\Code\Helpers;
+use Done\Subtitles\Code\UserException;
 use Done\Subtitles\Subtitles;
 use PHPUnit\Framework\TestCase;
 use Helpers\AdditionalAssertionsTrait;
@@ -192,6 +193,28 @@ public function testNonEnglishWords()
         $this->assertInternalFormatsEqual($expected, $actual);
     }
 
+    public function testNoTextDoesntThrowPhpException()
+    {
+        $this->expectException(UserException::class);
+
+        $actual = Subtitles::loadFromString('
+<SAMI>
+<HEAD>
+<STYLE TYPE="text/css">
+<!--  Generated by KMPlayer
+.[Local] Masked Avengers.srt	
+-->
+</STYLE>
+</HEAD>
+<BODY>
+<SYNC Start=20000><P Class=[Local] Masked Avengers.srt	>&nbsp;
+<SYNC Start=20000><P Class=[Local] Masked Avengers.srt	>&nbsp;
+<SYNC Start=20000><P Class=[Local] Masked Avengers.srt	>&nbsp;
+</BODY>
+</SAMI>
+        ')->getInternalFormat();
+    }
+
     // ---------------------------------- private ----------------------------------------------------------------------
 
     private static function fileContent()