Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleCop fixes for CShell.Hosting #81

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

StyleCop fixes for CShell.Hosting #81

wants to merge 2 commits into from

Conversation

theelderwand
Copy link

#80

@lukebuehler
Copy link
Owner

Thanks for this PR, I merged it locally, but also quickly realized that we need to be careful how we configure the settings.

I do not agree with all stylecop defaults and want to disable a few. I'm trying to set it up properly though based on your initial template.

@theelderwand
Copy link
Author

I already disabled a few where i felt like for example the documentation XML etc.
Please feel free to edit it and a template that we can work with.
As mentioned in the issue #80 i wanted to start off somewhere. Once you push a commit i'll start fixing the other projects and we can integrate it with build.
Also, I am quite curious about the roadmap, would it be possible for you to share one ?

@lukebuehler
Copy link
Owner

Yep, let me think some more about how to introduce stylecop gracefully. I think we should incrementally enable rules.

Re roadmap, here: https://github.com/lukebuehler/CShell/wiki/Roadmap

@theelderwand
Copy link
Author

Alright that works well too. Once a minimal set is ready, I'll start fixing the remaining projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants