Adding a condition to /list component #5222
Draft
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixed UI UX issue #359.
I propose not to display the component when switching from '/list' mobile to '/list' computer. This doesn't disturb the user's vision at all.
I've tried to test whether this fix could create other UI/UX problems, and so far I haven't found any.
I'm here to discuss the relevance of this solution.
Fixes #(issue)
#359
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
On mobile :
switch to '/list'
Then switch to computer mode
On computer : '/list'
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.