Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a condition to /list component #5222

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Logorrheique
Copy link

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [ x] I have read and understand the pull request rules.

Description

Fixed UI UX issue #359.

I propose not to display the component when switching from '/list' mobile to '/list' computer. This doesn't disturb the user's vision at all.

I've tried to test whether this fix could create other UI/UX problems, and so far I haven't found any.

I'm here to discuss the relevance of this solution.

Fixes #(issue)
#359

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

On mobile :

  • '/dashboard
    image

switch to '/list'

  • '/list'
    image

Then switch to computer mode

On computer : '/list'
image

image

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant