L-1147 Make sure filter_http_headers never modifies headers outside o…

…f logging (#17)
logtail · Jan 5, 2024 · 1281ebf · 1281ebf
1 parent 909e7a2
commit 1281ebf
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/logtail-rack/http_events.rb b/lib/logtail-rack/http_events.rb
@@ -269,10 +269,11 @@ def silenced?(env, request)
           end
 
           def filter_http_headers(headers)
-            headers.each do |name, _|
-              normalized_header_name = self.class.normalize_header_name(name)
-              headers[name] = "[FILTERED]" if self.class.http_header_filters&.include?(normalized_header_name)
-            end
+            headers.map do |name, value|
+              normalized_name = self.class.normalize_header_name(name)
+              is_filtered = self.class.http_header_filters&.include?(normalized_name)
+              [name, is_filtered ? "[FILTERED]" : value]
+            end.to_h
           end
 
           def safe_to_i(val)