fix(stringify): use safe-stable-stringify for stringifying json #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The current package, fast-safe-stringify, appears to hang on very large objects that contain circular references. Upon reading up on the issue from several packages open source packages its seems that this new package will handle these large circular refences. Albeit I am having a hard time duplicating the issue for testing.
TerryMooreII
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current package, fast-safe-stringify, appears to hang on very
large objects that contain circular references. Upon reading up
on the issue from several packages open source packages its seems
that this new package will handle these large circular references.
Albeit I am having a hard time duplicating the issue for testing.
Addressing issue #15