Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-3149] identity management - add clarification to the Name field #3199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

florentos17
Copy link

i am new to the repository tmail-flutter, but i saw this issue and it seemed pretty straightforward so i wanted to give it a try.

i changed the field label and the documentation, and corrected a few typos while i was at it. i apologize if i did things wrong !

@@ -1259,6 +1259,12 @@ class AppLocalizations {
name: 'name');
}

String get name_to_be_displayed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be use lowerCamelCase style for name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed !
actually, many similar getters are in snake_case style, for example:

tring get reply_to {
    return Intl.message(
        'Reply to',
        name: 'reply_to');
  }

  String get bcc_to {
    return Intl.message(
        'Bcc to',
        name: 'bcc_to');
  }

do you want me to change those as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants