Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow symfony 7 #248

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Nov 12, 2023

First try to support symfony 7.
I guess the problem is a bug with the virtual_request_stack which should already be fixed symfony/symfony@99a0dba.
But i still get the error.

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "debug.log_processor" has a dependency on a non-existent service ".virtual_request_stack".

@alexislefebvre
Copy link
Collaborator

I suggest to wait for the stable release of Symfony before working on this PR, using dev versions may bring more issues than expected.

@Chris53897
Copy link
Contributor Author

This is a good idea.
I just want to test my own bundle for symfony 7, that uses this bundle.

@Chris53897
Copy link
Contributor Author

Chris53897 commented Nov 16, 2023

This PR could probably fix it. See referenced Issue for more Details.
symfony/symfony#52604

Update: 7.0 RC2 did fixed this.

@Chris53897 Chris53897 changed the title feat: allow symfony 7 (WIP) feat: allow symfony 7 Nov 27, 2023
@Chris53897
Copy link
Contributor Author

@alexislefebvre Can you please review?

There is a failing (optional?) run.
Symfony ^7.0 on PHP 8.2 flags remove --dev --no-progress doctrine/phpcr-bundle doctrine/phpcr-odm
Your requirements could not be resolved to an installable set of packages.

@alexislefebvre
Copy link
Collaborator

phpcr/phpcr-utils only supports Symfony up to 6, see https://github.com/phpcr/phpcr-utils/blob/1.8.0/composer.json#L32

I don't understand why the CI is green when one step failed.

composer.json Outdated Show resolved Hide resolved
Chris53897 and others added 2 commits November 27, 2023 11:31
Co-authored-by: Alexis Lefebvre <alexislefebvre@gmail.com>
Co-authored-by: Alexis Lefebvre <alexislefebvre@gmail.com>
@Chris53897
Copy link
Contributor Author

There is already a PR at phpcr/phpcr-utils for Symfony 7 support.
phpcr/phpcr-utils#214

@Chris53897
Copy link
Contributor Author

I did commit your suggestions. But now there is no testrun for symfony 7.

@alexislefebvre
Copy link
Collaborator

My bad, I misread the composer-flags: "remove --dev … part. Please restore it. 🙇

@Chris53897
Copy link
Contributor Author

I reverted that change. CI fails becauseof minimum-stability, i removed in the other suggested commit.
Lets wait for a stable release of symfony and the other linked PR is merged.
It is not worth the effort to change the CI for 3 days.

@alexislefebvre alexislefebvre merged commit 0ae684e into liip:2.x Nov 30, 2023
9 checks passed
@alexislefebvre
Copy link
Collaborator

Thanks! Here is the last release: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.7.0

@Chris53897
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants