-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow symfony 7 #248
Conversation
5550a84
to
f12f82e
Compare
I suggest to wait for the stable release of Symfony before working on this PR, using |
This is a good idea. |
This PR could probably fix it. See referenced Issue for more Details. Update: 7.0 RC2 did fixed this. |
@alexislefebvre Can you please review? There is a failing (optional?) run. |
I don't understand why the CI is green when one step failed. |
Co-authored-by: Alexis Lefebvre <alexislefebvre@gmail.com>
Co-authored-by: Alexis Lefebvre <alexislefebvre@gmail.com>
There is already a PR at |
I did commit your suggestions. But now there is no testrun for symfony 7. |
My bad, I misread the |
I reverted that change. CI fails becauseof minimum-stability, i removed in the other suggested commit. |
Thanks! Here is the last release: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.7.0 |
Thanks |
First try to support symfony 7.
I guess the problem is a bug with the virtual_request_stack which should already be fixed symfony/symfony@99a0dba.
But i still get the error.
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "debug.log_processor" has a dependency on a non-existent service ".virtual_request_stack".