New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm-scripts): provide a flag to disable sass #1204

Merged

izaera merged 1 commit into liferay:master from izaera:sass_disable

Jun 5, 2024

Member

izaera commented Apr 18, 2024

I don't need this to be merged fast, but:

It makes sense since we already have disable flags for the rest of the toolling.
It will be handy when we start using the native sass compiler.

github-actions bot added npm-scripts npm-tools labels


          feat(npm-scripts): provide a flag to disable sass

3752f13

izaera force-pushed the sass_disable branch from 7786305 to 3752f13 Compare

June 5, 2024 07:34

Member Author

izaera commented Jun 5, 2024

The failure is due to the node version we use in Windows CI, not because of this PR, so going to merge...

izaera merged commit 388b80d into liferay:master

6 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm-scripts npm-tools