fix(@clayui/css): LPD-2001 c-prefers-expanded-text shouldn't use max-… #5864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matuzalemsteles
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
LGTM! It makes sense to me, I think we can go through this quickly and work on it more carefully. If I'm not mistaken we have something similar to do in tabs but the solution is to consider wrapping the rest of the items that are overflowing and putting them inside a drop down. Maybe we can consider this too, but we will still need JS.
|
@matuzalemsteles I agree, lmk if you want me to create another ticket to address the stacked tabs or dropdown issue. Edit: I actually created one recently https://liferay.atlassian.net/browse/LPD-34737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…width
https://liferay.atlassian.net/browse/LPD-2001
liferay-platform-experience/liferay-portal#689
This will only fix the stacked tab item text. We will add the functionality mentioned in #5622 in another pr. I wanted a CSS only solution, but it looks like we will need to implement in it in ClayTabs since we can't tell if tabs will break to new line. The tabs will look like the screenshot when expanded text and increased spacing.