Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@clayui/css): Cadmin Modal is outputing wrong selector for .modal… #5641

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(@clayui/css): Cadmin Modal is outputing wrong selector for .modal… #5641

merged 1 commit into from
Jul 19, 2023

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Jul 18, 2023

…-open .modal

fixes #5639 fixes #5528

matuzalemsteles
matuzalemsteles approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit 37ceb8a into liferay:master Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuzalemsteles matuzalemsteles matuzalemsteles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@clayui/css Cadmin modal doesn't have overflow-y: auto Modal doesn't allow for dynamically growing height.
2 participants
@pat270 @matuzalemsteles