Skip to content

Commit

Permalink
Clean up changelog for #332
Browse files Browse the repository at this point in the history
  • Loading branch information
lemon24 committed Jun 19, 2024
1 parent a325db6 commit b61019c
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 21 deletions.
43 changes: 23 additions & 20 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,20 @@ Version 3.13

Unreleased

* Update entries whenever their :attr:`~Entry.updated` changes,
don't compare the values. (:issue:`332`)
* Add :attr:`Feed.update_after` and :attr:`Feed.last_retrieved`. (:issue:`332`)
* The ``new`` filter of :meth:`~Reader.update_feeds()` etc. considers
a feed as new if it was never retrieved (:attr:`~Feed.last_retrieved`),
not if it was never updated successfully (:attr:`~Feed.last_updated`). (:issue:`332`)
* Add :meth:`~Reader.update_feeds()`, :meth:`~Reader.get_feeds()`, etc.
argument ``scheduled`` to allow updating only feeds scheduled to be updated.
See :ref:`scheduled` for details.
* Allow different feed update intervals; see :ref:`scheduled` for details.
(:issue:`332`)

.. FIXME: versionchanged on update_feeds() etc.
* Add ``scheduled`` argument to :meth:`~Reader.update_feeds()`,
:meth:`~Reader.get_feeds()`, etc.

* Add ``--scheduled`` flag to the ``update`` command. (:issue:`332`)
* Group mutually-exclusive attributes of :class:`~.FeedUpdateIntent`
into its :attr:`~.FeedUpdateIntent.value` union attribute. (:issue:`332`)
* New and improved :ref:`update` user guide section.
* Add :attr:`Feed.update_after` and :attr:`~Feed.last_retrieved` attributes.

* The ``new`` filter of :meth:`~Reader.update_feeds()` etc. considers
a feed new if it was never retrieved (:attr:`~Feed.last_retrieved`),
not if it was never updated successfully (:attr:`~Feed.last_updated`).

* The :mod:`~reader._plugins.cli_status` plugin now
records the output of multiple runs instead of just the last one,
with output from the same hour grouped in a single entry,
up to 24 entries (hours). (:issue:`332`)
* Update an entry whenever its :attr:`~Entry.updated` changes
(don't require it to be newer).

* Fix bug introduced in `version 3.12 <Version 3.12_>`_ causing an assertion error
when there are multiple entries with the same id in the same feed,
Expand All @@ -43,10 +35,21 @@ Unreleased

* Fix assertion error when an entry is deleted while being updated.

* Make it possible to re-run the :mod:`~reader.plugins.mark_as_read` plugin
for existing entries.
* Allow re-running the :mod:`~reader.plugins.mark_as_read` plugin for existing entries.
Thanks to `Michael Han`_ for the pull request.
(:issue:`317`)

* Other changes for scheduled updates. (:issue:`332`)

* Add ``--scheduled`` flag to the ``update`` command.
* The :mod:`~reader._plugins.cli_status` plugin now
records the output of multiple runs instead of just the last one,
with output from the same hour grouped in a single entry,
up to 24 entries/hours.
* Group mutually-exclusive attributes of :class:`~.FeedUpdateIntent`
into a new :attr:`~.FeedUpdateIntent.value` union attribute.

* New and improved :ref:`update` user guide section.
* Rename ``update --new-only`` CLI flag to ``--new``;
``--new-only`` remains available as an alias.
(:issue:`334`)
Expand Down
2 changes: 2 additions & 0 deletions docs/dev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,8 @@ Updating entries based on a hash of their content (regardless of ``updated``):

Decision to ignore feed.updated when updating feeds: :issue:`231`.

:ref:`scheduled` (initial design + postponed features): :issue:`322`.


.. _deleting entries:

Expand Down
1 change: 0 additions & 1 deletion docs/guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ the update will occur any time in the first 6 hours of the interval.
If you want feeds to be updated no more often than e.g. every hour,
you have to run :meth:`update_feeds(scheduled=True) <Reader.update_feeds>`
no more often than every hour.

Please :ref:`open an issue <issues>` if you need a minimum update interval.

In a future version of *reader*,
Expand Down
16 changes: 16 additions & 0 deletions src/reader/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,10 @@ def get_feeds(
.. versionadded:: 3.13
The ``scheduled`` keyword argument.
.. versionchanged:: 3.13
``new`` uses :attr:`~Feed.last_retrieved`
instead of :attr:`~Feed.last_updated`.
"""
filter = FeedFilter.from_args(
self._now(), feed, tags, broken, updates_enabled, new, scheduled
Expand Down Expand Up @@ -704,6 +708,10 @@ def get_feed_counts(
.. versionadded:: 3.13
The ``scheduled`` keyword argument.
.. versionchanged:: 3.13
``new`` uses :attr:`~Feed.last_retrieved`
instead of :attr:`~Feed.last_updated`.
"""
filter = FeedFilter.from_args(
self._now(), feed, tags, broken, updates_enabled, new, scheduled
Expand Down Expand Up @@ -855,6 +863,10 @@ def update_feeds(
.. versionadded:: 3.13
The ``scheduled`` keyword argument.
.. versionchanged:: 3.13
``new`` uses :attr:`~Feed.last_retrieved`
instead of :attr:`~Feed.last_updated`.
"""
hook_errors = self._update_hooks.group("some hooks failed")
try:
Expand Down Expand Up @@ -994,6 +1006,10 @@ def update_feeds_iter(
.. versionadded:: 3.13
The ``scheduled`` keyword argument.
.. versionchanged:: 3.13
``new`` uses :attr:`~Feed.last_retrieved`
instead of :attr:`~Feed.last_updated`.
"""
now = self._now()
filter = FeedFilter.from_args(
Expand Down

0 comments on commit b61019c

Please sign in to comment.