Add more generic EdDSA tests #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jakuje I stole (and rebased) one of your commits from #292 but otherwise just implemented basic test via changes to tcmpkeys and tgenkeys so they could be used in tests/tedwards My last commit changes tgenkey to remove custom detection given my general tgenkey changes allow us to call ED25519 checks only from the appropriate test script. |
|
Lovely, address sanitizer fails w/o a peep in the logs ... will look at it next week |
simo5
force-pushed
the
edtests
branch
2 times, most recently
from
367e431
to
d2c4440
Compare
Jakuje
reviewed
Apr 15, 2024
Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
- Make each key type test configurable via command argument - Call tgenkey from the basic test suite with proper arguments Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
This allow to use private URIs w/o interference. Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
approved these changes
Apr 15, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements tests requested in #272
Fixes #272
Checklist
Test suite updated with negative testsDocumentation updatedReviewer's checklist: