Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a genereic mechanism to block calls to tokens #378

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Apr 12, 2024

Description

Introduce a generic mechanism to block calls to a token.
Use this mechanism to reimplement the no_operation_state quirk.

Fixes #327

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5 simo5 requested a review from Jakuje April 12, 2024 14:33
src/pk11_uri.gen.c Show resolved Hide resolved
src/provider.c Outdated Show resolved Hide resolved
src/interface.h Outdated Show resolved Hide resolved
src/interface.pre Outdated Show resolved Hide resolved
src/provider.c Show resolved Hide resolved
@simo5
Copy link
Member Author

simo5 commented Apr 12, 2024

Uhmm I am not sure why the test fails ... investigating ...

And use this mechanism to reimplement the no_operation_state quirk.

Signed-off-by: Simo Sorce <simo@redhat.com>
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simo5 simo5 added the covscan Triggers Coverity Scanner label Apr 12, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Apr 12, 2024
@simo5 simo5 merged commit 093aba9 into latchset:main Apr 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend operation state quirk to cover all operation state operations.
2 participants