Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to run Coverity Scan on demand #365

Closed
wants to merge 1 commit into from

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Mar 25, 2024

Description

PR to change Coverity Scan to run on demand (by setting the covscan label) instead of running it after merge to main.
This way we can run the scan when the PR is still open and catch issues before merging.

Checklist

N/A

Reviewer's checklist:

  • Commits have short titles and sensible commit messages

@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added the covscan Triggers Coverity Scanner label Mar 25, 2024
@simo5 simo5 force-pushed the covscan_ondemand branch 2 times, most recently from 655e512 to dfcf301 Compare March 25, 2024 17:34
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
@simo5 simo5 added covscan Triggers Coverity Scanner and removed covscan Triggers Coverity Scanner labels Mar 25, 2024
This way we can run the scan when the PR is still open and catch issues
before merging.

Signed-off-by: Simo Sorce <simo@redhat.com>
@simo5 simo5 removed the covscan Triggers Coverity Scanner label Mar 25, 2024
@simo5
Copy link
Member Author

simo5 commented Mar 25, 2024

Testing this PR from a fork is basically impossible as no write permission are given nor secrets to run coverity.
Closing and opening a new one from an in-repository branch

@simo5 simo5 closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant