Restrict small and large shields max amount #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanedirt
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Hi @rautamik,
Thank you for your contribution! I just tested the changes, and they work flawlessly. I also reviewed the code, and it looks great—no comments from my side. Thanks for taking the time to add the unit test as well. Superb work 🚀!
Merging the changes! And welcome as an official contributor to OGameX! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Limit small and large shields maximum amount to one.
Disable build button when maximum number of shields is reached.
Hide number of items to be build input field when maximum number of shields is reached.
Show maximum number reached icon in structure selector when maximum number of shields is reached.
Add unit test for object service max build amount calculation
Related issue:
#212