refactor-#418: Added role type in frontend and backend #422
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @AMS003010! Thanks for sticking to the guidelines! High five! 🙌🏻 |
There was a problem hiding this comment.
Kindly make sure if the application is completely running without errors, because i straight away see, compilation issue. Didn't it catch while linting? If not kindly let me know... while commit it should ideally run the eslint --fix . and give errors, not sure how this slided from there
|
Hi @AMS003010 can you kindly address the review comments and close this by today? |
backend/types/role-type.tsx
Outdated
There was a problem hiding this comment.
I still doubt if this is working, because the backend is not still not ts compatible, how where you able to define tsx?
Did it compile succesfully? It ideally shouldn't @AMS003010 .
Or you might have just refactored and didn't actually run the application. Correct?
I'm confused how the builds are passing !!
There was a problem hiding this comment.
Yeah I actually didn't run the application 😅
There was a problem hiding this comment.
Let me just see...
@AMS003010 kindly run the application and push the required changes |
|
@AMS003010 did you run the application? |
|
@krishnaacharyaa |
|
@krishnaacharyaa Thanks a lot for the help 😁 |
Summary
I have added the role type (as an enum) in both the backend and frontend and replaced the "USER" and "ADMIN" types with
Role.UserandRole.AdminDescription
Explain in detail what this PR is all about. This should include the problem you're solving, the approach taken, and any technical details that reviewers need to know.
Images
None
Issue(s) Addressed
Closes Issue #418
Prerequisites