Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Adding user type in frontend #418

Closed
devsharmagit opened this issue Jun 17, 2024 · 6 comments · Fixed by #422
Closed

[ENHANCEMENT] Adding user type in frontend #418

devsharmagit opened this issue Jun 17, 2024 · 6 comments · Fixed by #422
Assignees
Labels
enhancement Enhancement to the existing code gssoc Issue can be taken under GSSoC level1

Comments

@devsharmagit
Copy link
Contributor

Description

Right now frontend does not have a user type in the types folder. User types need to be added in the types folder for better type checking. and prevent future bugs.

Current Behavior

No user type in frontend types folderthe folder

Proposed Enhancement

add a user type on frontend type folder and use it everywhere.

Use Case

This will prevent future bugs and clean code format.

Blockers

No response

Additional Information/ Attachments

No response

@devsharmagit devsharmagit added the enhancement Enhancement to the existing code label Jun 17, 2024
@AMS003010
Copy link
Contributor

Hello @krishnaacharyaa 🤗

Please do assign me this issue under gssoc'24

Thank you

@krishnaacharyaa
Copy link
Owner

Hi @AMS003010, sure,
In backend in one place there is this role type, you got to lift it up to the root level and have a type in a types folder if not already exists, same goes with frontend, and where ever there is "ADMIN" "USER" string hard coded, it needs to be replaced with the Role.User or Role.Admin .... take care of the naming conventions if needs to be upper case or lower case by referring to the other defined types in the project

Copy link

Hey @AMS003010 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

@AMS003010
Copy link
Contributor

@krishnaacharyaa I have made the PR
Please do review it.

AMS003010 added a commit to AMS003010/wanderlust that referenced this issue Jun 19, 2024
@AMS003010
Copy link
Contributor

@krishnaacharyaa I have made the PR
Please do review it.
Sorry 😅 for the delay, I was doubtful as to if the type should be applied for the mongo schema as well.

AMS003010 added a commit to AMS003010/wanderlust that referenced this issue Jun 20, 2024
@AMS003010
Copy link
Contributor

@krishnaacharyaa I have made the fix, please do review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the existing code gssoc Issue can be taken under GSSoC level1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants