Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bypass rule #34

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement bypass rule #34

wants to merge 6 commits into from

Conversation

koddsson
Copy link
Owner

No description provided.

Copy link

LCOV of commit f72b38b during CI #155

	(use "lcov --ignore-errors deprecated,deprecated ..." to suppress this warning)
Reading tracefile /var/folders/b3/2xm02wpd21qgrpkck5q1c6k40000gn/T/__koddsson_github-actions-report-lcov/lcov.info.
Summary coverage rate:
  source files: 26
  lines.......: 91.9% (1380 of 1501 lines)
  functions...: 95.3% (41 of 43 functions)
  branches....: 88.4% (311 of 352 branches)
Message summary:
  1 warning message:
    deprecated: 1

Files changed coverage rate:
  	(use "lcov --ignore-errors deprecated,deprecated ..." to suppress this warning)
                                    |Lines       |Functions  |Branches    
  Filename                          |Rate     Num|Rate    Num|Rate     Num
  src/rules/area-alt.ts             | 100%     22| 100%     1| 100%      9
  src/rules/aria-hidden-body.ts     |57.9%     19| 100%     1|33.3%      3
  src/rules/aria-tooltip-name.ts    |61.2%     49| 100%     2|40.0%      5
  src/rules/aria-valid-attr-value.ts|91.7%    109| 100%     2|90.9%     66
  src/rules/aria-valid-attr.ts      | 100%     42| 100%     1|77.8%      9
  src/rules/audio-caption.ts        | 100%     25| 100%     1|66.7%      3
  src/rules/button-name.ts          | 100%     51| 100%     2| 100%     24
  src/rules/bypass.ts               |67.9%     28| 100%     1|25.0%      4
  src/rules/duplicate-id-aria.ts    |92.3%     26| 100%     1|40.0%      5
  src/rules/html-has-lang.ts        |84.2%     19| 100%     1|25.0%      4
  src/rules/image-alt.ts            | 100%     38| 100%     1| 100%     22
  src/rules/input-button-name.ts    | 100%     42| 100%     1|88.9%     18
  src/rules/input-image-alt.ts      | 100%     31| 100%     1|85.7%     14
  src/rules/label.ts                |95.9%     49| 100%     1|95.0%     20
  src/rules/link-name.ts            |85.1%     67| 100%     1|75.0%     24
  src/rules/meta-refresh.ts         | 100%     23| 100%     1| 100%      4
  src/rules/meta-viewport.ts        | 100%     40| 100%     2| 100%      8
  src/rules/nested-interactive.ts   | 100%     40| 100%     1| 100%      4
  src/rules/scope-attr-valid.ts     |90.0%     60| 100%     3|75.0%     12
  src/rules/select-name.ts          |95.7%     46| 100%     1|94.1%     17
  src/rules/valid-lang.ts           |97.1%     69| 100%     3|95.5%     22
  src/rules/video-caption.ts        | 100%     35| 100%     1| 100%      5
  src/scanner.ts                    |70.8%     96|66.7%     3|71.4%      7

@koddsson
Copy link
Owner Author

This needs tests and was not caught by the coverage checker which makes the coverage checker a bit useless!

@koddsson
Copy link
Owner Author

Some of the tests are failing because the bypass rule is triggering in unrelated test suites. We'd need to isolate them better by not running the scanner in the tests with all the rules enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant