Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpHeaders #37

Merged
merged 4 commits into from
Oct 16, 2024
Merged

HttpHeaders #37

merged 4 commits into from
Oct 16, 2024

Conversation

joanne-ter-maat
Copy link
Collaborator

Fixed issues found with the use of httpheaders and added testcases.

ricardoboss
ricardoboss approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ricardoboss ricardoboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Just a suggestion but otherwise good to go

packages/kiota_abstractions/lib/src/case_insensitive_map.dart Outdated Show resolved Hide resolved
@joanne-ter-maat @ricardoboss
call normalizeKey(key) once and only modify the list if actually absent
106825b 
Co-authored-by: Ricardo Boss <mail@ricardoboss.de>
@ricardoboss ricardoboss merged commit 27b355c into main Oct 16, 2024
13 checks passed
@ricardoboss ricardoboss deleted the fixes/httpheaders branch October 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoboss ricardoboss ricardoboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanne-ter-maat @ricardoboss