Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added version 1 to ORDER_DEFINITIONS #581

Merged
merged 1 commit into from
Mar 13, 2024
Merged

added version 1 to ORDER_DEFINITIONS #581

merged 1 commit into from
Mar 13, 2024

Conversation

jwildman135
Copy link
Contributor

  • Version 1 LAS files have the same ORDER_DEFINITIONs as Version 1.2 LAS files.
  • Currently Version 1 LAS files produce a key error.
  • I propose adding Version 1 LAS files to the ORDER_DEFINITIONS, with the same definition as Version 1.2 LAS files, to allow support for this version.

kinverarity1
kinverarity1 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Owner

@kinverarity1 kinverarity1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. I apologise for the delay in approving.

@kinverarity1 kinverarity1 merged commit e33edd9 into kinverarity1:main Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinverarity1 kinverarity1 kinverarity1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwildman135 @kinverarity1