Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback Form #2099

Closed
wants to merge 36 commits into from
Closed

Feedback Form #2099

wants to merge 36 commits into from

Conversation

rashidakanchwala
Copy link
Contributor

Description

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen added 30 commits September 6, 2024 10:52
first skeleton for the feedback component
339166a 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
star component
131f138 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include feedback button
d34adc1 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
send data to heap through feedback
219d4b0 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
remove unused prop and component
e88317c 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'main' into feature/feedback-form
830225e
add title for feedback button
a5d5de9 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
mood board
ba23f57 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
update with final design
8f07236 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include messages
2d47972 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
move to Feedback wrapper instead
f3c2e71 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
add local storage to track first time
f3e71f8 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
add key for Mood component
278be58 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
draft version of local storage
6194843 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
update styling
ffbce1a 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
break the title into 2 lines
fd1646e 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
move mood to its own component
075b03f 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include the release note
28fde20 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'main' into feature/feedback-form
1eaa1ba
fix eslint error
172b939 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Separate feedback to feedback-button and feedback-form to suit the logic
bca6d90 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
tidy up code
bc8aea0 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
remove unused icon and components
efa5c91 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
add transition for feedback-form and button
d4eed38 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include new message for cancel event
997d902 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
update localStorage name
c131729 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
move feedback to config
73e0c68 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'main' into feature/feedback-form
3f5270d
update text area colour
46f9e27 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
update font-size for text area and hover state for button
5787fef 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Huong Nguyen added 6 commits September 17, 2024 15:18
update font for place holder in text area
b3139d5 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
update font for place holder in text area in feedback
b10de5c 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'main' into feature/feedback-form
72108b9 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'main' into feature/feedback-form
291819e
re-run the test
72088f7 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include classnames for icons
2eb4350 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg
Copy link
Contributor

Huongg commented Sep 18, 2024

Closed as its already resolved

@Huongg Huongg closed this Sep 18, 2024
@Huongg Huongg deleted the feedback-form-2 branch September 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@jitu5 jitu5 Awaiting requested review from jitu5 jitu5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashidakanchwala @Huongg