-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnavailableDataset as a default dataset for lite mode #2083
Conversation
Thanks @ravi-kumar-pilla - could you clarify what was the situation before this PR? |
Hi @astrojuanlu , Thanks for reviewing. Before this change, the default was |
Thanks for reviewing. Yes these are actually MemoryDatasets (as they are not registered in the DataCatalog). We will show For example, companies:
type: pandas.CSVDataset
filepath: ${_base_location}/01_raw/companies.csv
metadata:
kedro-viz:
layer: raw
preview_args:
nrows: 5 |
@ravi-kumar-pilla understood, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks! <3
Description
Related to #2058
Development notes
UnavailableDataset
MemoryDataset
toUnavailableDataset
in--lite
mode.N/A
instead of-
as suggested by @stephkaiserQA notes
kedro viz --lite
withkedro-datasets
missing in the conda env, the metadata panel for the dataset should show the dataset type asUnavailableDataset
if the dataset is mentioned in catalog.py (i.e., not a MemoryDataset)Checklist
RELEASE.md
file