Skip to content

Commit

Permalink
matrix for js removed
Browse files Browse the repository at this point in the history
  • Loading branch information
jitu5 committed Apr 9, 2024
1 parent db418b2 commit ed92744
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/all-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,4 @@ jobs:
python-version: ${{ matrix.python-version }}

javascript_lint_and_tests:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.9" ]
uses: ./.github/workflows/javascript-lint-and-tests.yml
with:
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
17 changes: 6 additions & 11 deletions .github/workflows/javascript-lint-and-tests.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,27 @@
name: Run javascript linters and tests on Kedro-Viz
# Runs JavaScript linting, unit tests, and end-to-end tests on
# Kedro-Viz for different operating systems and Python versions.
# Kedro-Viz for ubuntu-latest operating systems and Python 3.9.

on:
workflow_call:
inputs:
os:
type: string
python-version:
type: string

jobs:
javascript_lint_and_tests:
runs-on: ${{ inputs.os }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python ${{inputs.python-version}}
- name: Set up Python "3.9"
uses: actions/setup-python@v5
with:
python-version: ${{inputs.python-version}}
python-version: "3.9"

- name: Cache python packages for Linux
if: inputs.os == 'ubuntu-latest'
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{inputs.os}}-python-${{inputs.python-version}}
key: ubuntu-latest-python-3.9

- name: Install Kedro and other Python Dependencies
uses: "./.github/actions/install_python_dependencies"
Expand Down

0 comments on commit ed92744

Please sign in to comment.