Fix potential panic in create_http_context #183
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
junr03
commented
Oct 13, 2024
| @@ -282,7 +282,10 @@ impl RootContext for FilterContext { | |||
| // No StreamContext can be created until the Embedding Store is fully initialized. | |||
| let embedding_store = match self.mode { | |||
| GatewayMode::Llm => None, | |||
| GatewayMode::Prompt => Some(Rc::clone(self.embeddings_store.as_ref().unwrap())), | |||
There was a problem hiding this comment.
this unwrap can panic if a stream is being created before the embeddings store has finished initializing
adilhafeez
reviewed
Oct 13, 2024
| @@ -282,7 +282,10 @@ impl RootContext for FilterContext { | |||
| // No StreamContext can be created until the Embedding Store is fully initialized. | |||
| let embedding_store = match self.mode { | |||
| GatewayMode::Llm => None, | |||
| GatewayMode::Prompt => Some(Rc::clone(self.embeddings_store.as_ref().unwrap())), | |||
| GatewayMode::Prompt => match self.embeddings_store.as_ref() { | |||
| None => return None, | |||
There was a problem hiding this comment.
Suggested change
| None => return None, | |
| None => None, |
adilhafeez
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: José Ulises Niño Rivera junr03@users.noreply.github.com